Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofocus effect #192

Merged
merged 5 commits into from
May 2, 2023
Merged

Autofocus effect #192

merged 5 commits into from
May 2, 2023

Conversation

abernier
Copy link
Member

@abernier abernier commented Apr 30, 2023

Note Merged
see <Autofocus> doc

Based on @ektogamat work and pmndrs/postprocessing DepthOfFieldEffect, <Autofocus> effect extends <DepthOfField> and drives its target.

autofocus-suzi-v2.mov

Demo here: https://codesandbox.io/s/dfw6w4?file=/src/Autofocus.tsx

  • Documentation updated
  • Ready to merge

@abernier abernier force-pushed the abernier/autofocus branch from 7593ea8 to a0702b8 Compare April 30, 2023 10:15
@ektogamat
Copy link
Contributor

Great work my friend. Happy that this will become official 😊✌🏻

src/Autofocus.tsx Outdated Show resolved Hide resolved
@talentlessguy
Copy link
Member

Could you please add a page to docs/effects instead of README?

@talentlessguy talentlessguy requested a review from drcmda April 30, 2023 11:50
@abernier abernier mentioned this pull request Apr 30, 2023
3 tasks
@abernier abernier force-pushed the abernier/autofocus branch from d8076d7 to 963ab96 Compare April 30, 2023 18:38
@ektogamat
Copy link
Contributor

Can I help with something? Documentation maybe? I have no idea how to contribute hehehe. Just want to be useful if needed, okay? 🫶🏻

src/Autofocus.tsx Show resolved Hide resolved
src/Autofocus.tsx Outdated Show resolved Hide resolved
src/Autofocus.tsx Outdated Show resolved Hide resolved
@abernier abernier force-pushed the abernier/autofocus branch 2 times, most recently from 84be37b to 3ca723a Compare May 2, 2023 07:29
@abernier abernier force-pushed the abernier/autofocus branch from 3ca723a to ee87945 Compare May 2, 2023 07:30
@abernier abernier requested a review from drcmda May 2, 2023 07:36
@abernier abernier marked this pull request as draft May 2, 2023 11:30
@abernier abernier marked this pull request as ready for review May 2, 2023 14:56
@abernier abernier merged commit 9d1f77e into pmndrs:master May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ektogamat
Copy link
Contributor

AMAZING WORK GUYS 👏🏻👏🏻👏🏻🫶🏻

@abernier abernier deleted the abernier/autofocus branch May 2, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants